FEAT: Twinbuilder excitation component #4752
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
gmalinve
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4752 +/- ##
==========================================
- Coverage 82.67% 77.98% -4.69%
==========================================
Files 117 117
Lines 54186 54249 +63
==========================================
- Hits 44797 42308 -2489
- Misses 9389 11941 +2552 |
PipKat
reviewed
Jun 5, 2024
| Use the excitation component to assign output quantities in a Twin Builder design to a windings | ||
| in a Maxwell design. | ||
|
|
||
| This method works only with AEDT versions > 2024 R2. |
There was a problem hiding this comment.
Suggested change
| This method works only with AEDT versions > 2024 R2. | |
| This method works only with AEDT 2024 R2 and later. |
PipKat
reviewed
Jun 5, 2024
| start : float, optional | ||
| Start time. | ||
| The default value is ``None``. | ||
| If not provided and ``use_default_values`` is ``True`` the value is chosen from the TR setup. |
There was a problem hiding this comment.
Suggested change
| If not provided and ``use_default_values`` is ``True`` the value is chosen from the TR setup. | |
| If not provided and ``use_default_values=True``, the value is chosen from the TR setup. |
PipKat
reviewed
Jun 5, 2024
| stop : float, optional | ||
| Stop time. | ||
| The default value is ``None``. | ||
| If not provided and ``use_default_values`` is ``True`` the value is chosen from the TR setup. |
There was a problem hiding this comment.
Suggested change
| If not provided and ``use_default_values`` is ``True`` the value is chosen from the TR setup. | |
| If not provided and ``use_default_values=True``, the value is chosen from the TR setup. |
PipKat
reviewed
Jun 5, 2024
Comment on lines
+619
to
+620
| If ``True``, Twin Builder performs linear interpolation to uniformly space out time and data points. | ||
| The interpolation is based on the step size provided. |
There was a problem hiding this comment.
Suggested change
| If ``True``, Twin Builder performs linear interpolation to uniformly space out time and data points. | |
| The interpolation is based on the step size provided. | |
| Whether Twin Builder is to perform linear interpolation to uniformly space out time and data points. | |
| The interpolation is based on the step size provided. The default is ``False``. |
PipKat
reviewed
Jun 5, 2024
Comment on lines
+622
to
+623
| Step size used for the uniform interpolation. | ||
| The default value is ``1E-5``. |
There was a problem hiding this comment.
Suggested change
| Step size used for the uniform interpolation. | |
| The default value is ``1E-5``. | |
| Step size to use for the uniform interpolation. | |
| The default value is ``1E-5``. |
PipKat
reviewed
Jun 5, 2024
| >>> oComponentManager.AddExcitationModel | ||
| """ | ||
| if self.aedt_version_id < "2024.2": | ||
| self.logger.error("This method only work for AEDT versions > 2024 R2.") |
There was a problem hiding this comment.
Suggested change
| self.logger.error("This method only work for AEDT versions > 2024 R2.") | |
| self.logger.error("This method only work for AEDT 2024 R2 and later.") |
PipKat
reviewed
Jun 5, 2024
| twin_app = dkp[[project, self.design_name]] | ||
| project_selection = 0 | ||
| else: | ||
| raise ValueError("Invalid project name or path provided.") |
There was a problem hiding this comment.
Suggested change
| raise ValueError("Invalid project name or path provided.") | |
| raise ValueError("Invalid project name or path is provided.") |
Messages should have subject, verb, and concluding punctuation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.