Doc/tb example 2025r1 #5226
Draft
Doc/tb example 2025r1 #5226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
chrpetre
commented
Sep 30, 2024
| ] | ||
| ]) | ||
|
|
||
| # Add Datapairs component pin so that its location can directly be retrieved #TODO - how to fix this as part of CircuitComponent/pins class |
There was a problem hiding this comment.
@Samuelopez-ansys I would appreciate some review on that part, as I needed to explicitly add the list of pins to get their position through 'location' and use for the create_wire function below. In other words, I would expect the ...pins[xxx].location to work on any component added on the schematic but for some reasons the logic does not work for the Datapairs block added, hence I needed to create/add the list of pins explicitly (similarly to what is done in the CircuitComponent class)
github-actions
bot
added
examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new Twin Builder example showing the creation of LTI ROM, simulation of the model and post processing of the results
It also performs a few small updates on existing examples