Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: General improvements in Icepak #5728

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SMoraisAnsys
Copy link
Collaborator

Description

Follow up of #5695 applied to Icepak

Issue linked

Associated to #5504

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 7.14286% with 39 lines in your changes missing coverage. Please review.

Project coverage is 44.20%. Comparing base (3c863dc) to head (3a44ba1).

❌ Your patch check has failed because the patch coverage (7.14%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5728       +/-   ##
===========================================
- Coverage   85.20%   44.20%   -41.01%     
===========================================
  Files         156      156               
  Lines       61070    61051       -19     
===========================================
- Hits        52037    26989    -25048     
- Misses       9033    34062    +25029     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant