Skip to content

FEAT: Ability to connect components #6300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 141 commits into
base: main
Choose a base branch
from
Draft

FEAT: Ability to connect components #6300

wants to merge 141 commits into from

Conversation

ramin4667
Copy link
Contributor

Description

This PR adds a function to connect 2 emit components.

Issue linked

NA.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

jsalant22 and others added 30 commits January 22, 2025 10:13
@jsalant22
EMIT API branch
935d091 
Reconfigure Revision class for some API changes
@bryankaylor
Add first draft of generated nodes and basic interface
f14755b
@bryankaylor
New version of generated nodes
4aef45e
@bryankaylor
Updated generated nodes and interface
3cce1c1
@bryankaylor
Add generated module init file, update EmitNode
04c4218
@bryankaylor
Add node functions for getting children
3f33e2a
@bryankaylor
Update generated nodes spacing and add_ methods, move NodeInterface m…
bfef0cf 
…ethods to Revision and make revision-aware, add methods for getting individual top level nodes
@bryankaylor
Add equality operator to EmitNode class
3aac82f
@bryankaylor
Remove equality operator from generated nodes
70100fd
@jsalant22
update revision and result classes for api changes
84f6c32 
Update the revision/result classes to support new api
@jsalant22
Merge branch 'F932911' of https://github.com/ansys/pyaedt into F932911
5d0ece1
@jsalant22
use display names for access nodes
68034da 
use display names for access nodes
@jsalant22
add units support
fcee90c 
add units support
@jsalant22
fix unit parsing
c280da2 
fix conversion from string to decimal+string
@bryankaylor
Add updated generated nodes, fix emit allowed unit names, fix emit de…
32060dd 
…fault units
@bryankaylor
Fix revision constructor for 252, fix units
6a06ab5
@bryankaylor
Update results and revision modules to use new result API
5501be5
@bryankaylor
Revert change of GetKeptResultProperties to GetResultProperties
0633784
@jsalant22 @pre-commit-ci
Add EmitterBand and TxSpectralProfEmitter classes (#6048)
f5b5780 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@bryankaylor
Add test for generated nodes
5a01894
@bryankaylor
Fix merge conflict
55bb89d
@jsalant22 @pre-commit-ci
Add warning for disconnected comps (#6056)
726e6d4 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@jsalant22
F1251272 (#6063)
4b68e24
@bryankaylor
Add dynamic generated node test
95189be
@bryankaylor
Fix conflict
39fd586
@bryankaylor
Fix merge conflicts for files deleted in main
98d0248
@pre-commit-ci
CHORE: Auto fixes from pre-commit hooks
5fba8f8
@pyansys-ci-bot
chore: adding changelog file 6068.added.md [dependabot-skip]
4c74e09
@bryankaylor
Re-delete readded files
16d567f
@bryankaylor
Merge branch 'F932911' of ssh://ssh.github.com:443/ansys/pyaedt into …
05e89d9 
…F932911
@jsalant22
Copy link
Contributor

@bryankaylor Can you help resolve these conflicts and get this merged with the main feature branch? I'm guessing most of the conflicts are just due to updates to the generated nodes.

Base automatically changed from F932911 to main July 22, 2025 12:40
@bryankaylor
Copy link
Contributor

bryankaylor commented Jul 22, 2025 •
edited
Loading

@bryankaylor Can you help resolve these conflicts and get this merged with the main feature branch? I'm guessing most of the conflicts are just due to updates to the generated nodes.

@jsalant22 Looks like this PR automatically updated the target branch to main after the other PR merged. I've fixed the conflicts here and the diff looks good!

jsalant22
jsalant22 reviewed Jul 25, 2025
View reviewed changes
jsalant22
jsalant22 previously approved these changes Jul 25, 2025
View reviewed changes
@ansys-cla-bot
Copy link

ansys-cla-bot bot commented Aug 6, 2025

The following people have not signed the Contributors License Agreement (CLA):

Read the CLA in the link above and sign it by clicking the link below:

You will receive a confirmation as soon as your signature is captured.

@Samuelopez-ansys
Copy link
Member

This PR has been open for a long time. I will move it to draft until it is fixed locally. @ramin4667

@Samuelopez-ansys Samuelopez-ansys marked this pull request as draft September 3, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsalant22 jsalant22 jsalant22 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ramin4667 @jsalant22 @bryankaylor @Samuelopez-ansys @pyansys-ci-bot @SMoraisAnsys