FEAT: Project Sheet #6698
FEAT: Project Sheet #6698
Conversation
|
All Contributor License Agreement (CLA) signatures have been captured successfully. Thanks for contributing! |
There was a problem hiding this comment.
Hey @boltma, thanks a lot for this great contribution !
I'll have a look to test the code locally today, I left some comments in the mean time.
| ], | ||
| ) | ||
| unclassified_new = [i for i in self.unclassified_objects if i not in unclassified] | ||
| if unclassified_new: # pragma: no cover |
There was a problem hiding this comment.
Do you think that you could remove that pragma: no cover and add a unit test (using mocking / monkeypatch) to cover that scenario ?
There was a problem hiding this comment.
Thanks for the feedback. I’ve updated the test, though I’m not sure I have followed the best practice.
There was a problem hiding this comment.
I was thinking about adding a test inside of tests/unit, not tests/system but thanks for trying that :)
Since you are not part of the ansys organization on GitHub we can't use your PR to run the CI which runs on self-hosted runners. I'll cherry-pick your changes and create a new PR so that you are still the author of those changes and we can make it run the CI. If that's fine with you, I can also see how to add the mentionned tests/unit changes. Would that be fine for you ?
There was a problem hiding this comment.
Sry for the delay, I'll have a look in the PR next week. This week was super busy. Thanks again for the contribution and your patience.
Description
Add project_sheet method to modeler.
Issue linked
#5360
Checklist