Skip to content

Conversation

jvela018
Copy link
Contributor

@jvela018 jvela018 commented Oct 2, 2025

Description

Use solution_type in create_output_variable method when calling the native API

Issue linked

#6724

@jvela018 jvela018 requested a review from a team as a code owner October 2, 2025 09:49
@jvela018 jvela018 linked an issue Oct 2, 2025 that may be closed by this pull request
2 tasks
@jvela018 jvela018 self-assigned this Oct 2, 2025
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.92%. Comparing base (85e36c7) to head (bec42aa).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6726       +/-   ##
===========================================
- Coverage   83.19%   27.92%   -55.27%     
===========================================
  Files         245      245               
  Lines       77265    77265               
===========================================
- Hits        64280    21579    -42701     
- Misses      12985    55686    +42701     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment :)

gmalinve
gmalinve previously approved these changes Oct 2, 2025
@jvela018 jvela018 requested a review from gmalinve October 3, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create_output_variable doesn't work in Maxwell
4 participants