Skip to content

Conversation

@jsalant22
Copy link
Contributor

@jsalant22 jsalant22 commented Oct 30, 2025

Remove some Savant specific keys

Fix _is_component() logic

Use EmitNode.name setter instead of a separate rename() function

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

Remove some Savant specific keys

Fix _is_component() logic

Use EmitNode.name setter instead of a separate rename() function
@jsalant22 jsalant22 requested a review from a team as a code owner October 30, 2025 17:02
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 53.94191% with 222 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.50%. Comparing base (1c8651a) to head (bde5c48).

❌ Your patch check has failed because the patch coverage (53.94%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6835      +/-   ##
==========================================
- Coverage   83.28%   82.50%   -0.78%     
==========================================
  Files         245      245              
  Lines       77681    77100     -581     
==========================================
- Hits        64694    63614    -1080     
- Misses      12987    13486     +499     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @jsalant22, I left some comments

@github-actions github-actions bot added the maintenance Package and maintenance related label Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants