Skip to content

Conversation

@jvela018
Copy link
Contributor

@jvela018 jvela018 commented Nov 4, 2025

Description

The method set_coreloss_at_frequency can be used for a single frequency or multiple frequencies. The method was able to set up the frequencies, but was unable to populate the data on the tables. The API argument setup for the Points argument was done in two places - the _dict2arg method and the get_frequency_coefficients method. Unfortunately, the one being handled in _dic2arg, didn't modify the global props under self._props, and it was handled via the get_frequency method. The coefficients were calculated correctly, but the datasets weren't updated.

The issue was fixed by removing the handling of the API Points definition within the get_frequency_coefficient, and exposed it directly through the data_handlers.py.

Issue linked

#6818

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@jvela018 jvela018 requested a review from a team as a code owner November 4, 2025 15:02
@github-actions github-actions bot added the bug Something isn't working label Nov 4, 2025
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.48%. Comparing base (5d5ecf8) to head (fcb0d8a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6851      +/-   ##
==========================================
- Coverage   83.48%   83.48%   -0.01%     
==========================================
  Files         245      245              
  Lines       77614    77609       -5     
==========================================
- Hits        64798    64792       -6     
- Misses      12816    12817       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants