Skip to content

Conversation

@isaacwaldron
Copy link
Contributor

Downgrade log message when an error occurs while iterating processes to search for ansysedt sessions. Rationale:

  1. If any error occurs during the ansysedt session search process loop, the end result is that the process in question is not returned as a potential ansysedt session. This is generally not harmful.
  2. There is nothing the user could have done to make the error not occur: they have no control over the processes on the machine, the behavior of psutil, or the logic in this loop.
  3. Downgrading to debug allows us to also log the full stack trace of the exception, allowing us to identify fixes to the logic for cases that fail in the future.

Closes #6852

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@isaacwaldron isaacwaldron requested a review from a team as a code owner November 4, 2025 22:04
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.48%. Comparing base (1c8651a) to head (74dbbba).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6853      +/-   ##
==========================================
+ Coverage   83.28%   83.48%   +0.20%     
==========================================
  Files         245      245              
  Lines       77681    77681              
==========================================
+ Hits        64694    64851     +157     
+ Misses      12987    12830     -157     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

isaacwaldron and others added 2 commits November 7, 2025 09:29
Downgrade log message when an error occurs while iterating processes to
search for ansysedt sessions.  Rationale:

1. If any error occurs during the ansysedt session search process loop,
   the end result is that the process in question is not returned as a
   potential ansysedt session.  This is generally not harmful.
2. There is nothing the user could have done to make the error not
   occur: they have no control over the processes on the machine, the
   behavior of `psutil`, or the logic in this loop.
3. Downgrading to debug allows us to also log the full stack trace of
   the exception, allowing us to identify fixes to the logic for cases
   that fail in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Downgrade error message during ansysedt session search to debug level

3 participants