Skip to content

Conversation

@eblanco-ansys
Copy link
Contributor

Description

Reverted how installation script displays log messages for panels. run_pyinstaller_from_c_python method was uncorrectly implemented, passing an static "odesktop" string to add_pyaedt_to_aedt. This leaded to an error

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@eblanco-ansys eblanco-ansys requested a review from a team as a code owner November 6, 2025 15:59
@github-actions github-actions bot added the bug Something isn't working label Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.48%. Comparing base (f14d309) to head (042bc2f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6864      +/-   ##
==========================================
+ Coverage   81.53%   83.48%   +1.95%     
==========================================
  Files         245      245              
  Lines       77614    77614              
==========================================
+ Hits        63284    64798    +1514     
+ Misses      14330    12816    -1514     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK this won't work for the same reasons as the one that had to be handled in #6803 (comment), aka communicate() raises an exception in Linux. Can you ensure that it works before passing the PR as ready to be reviewed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants