Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin aliases #2059

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Pin aliases #2059

wants to merge 10 commits into from

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Feb 7, 2025

This PR exposes APIs for pin name aliases in PyDPF-Core, along with a template update for operator module generation to enable retro-compatibility of scripts using aliases, as well as warning about deprecation of said aliases.

@PProfizi PProfizi added the enhancement New feature or request label Feb 7, 2025
@PProfizi PProfizi self-assigned this Feb 7, 2025
@PProfizi PProfizi requested a review from a team as a code owner February 7, 2025 17:30
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.84%. Comparing base (50d0208) to head (ee192a5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2059      +/-   ##
==========================================
- Coverage   86.40%   82.84%   -3.57%     
==========================================
  Files          90       90              
  Lines       10233    10248      +15     
==========================================
- Hits         8842     8490     -352     
- Misses       1391     1758     +367     

@PProfizi PProfizi force-pushed the feat/handle_pin_aliases branch from fe19730 to cb64399 Compare February 10, 2025 13:48
@PProfizi PProfizi force-pushed the feat/handle_pin_aliases branch from cb64399 to b0a557e Compare February 10, 2025 13:56
@PProfizi PProfizi force-pushed the feat/handle_pin_aliases branch from b0a557e to ee192a5 Compare February 10, 2025 14:42
@PProfizi
Copy link
Contributor Author

Here is an example of a server sync update with the current changes (plus a few others due to diff with master):
https://github.com/ansys/pydpf-core/pull/2067/files

@rafacanton
Copy link
Contributor

@PProfizi This looks nice, also the operator code update. Can we add a test to ensure that we get the warning when we try to connect op.inputs.ponderation? Of course, when we eliminate ponderation in the future, the test will crash and we just remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants