Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only ask integration_proxies for review for operator updates on main branch #2068

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Feb 10, 2025

While running test operator update actions, the integration_proxies keep being added as reviewer despite the generated PR being on a feature branch.
This limits it to operator update PRs on the default branch.

See here for example of if/else in GitHub actions expressions.

@PProfizi PProfizi added the CI/CD Related to CI/CD label Feb 10, 2025
@PProfizi PProfizi requested a review from rafacanton February 10, 2025 15:05
@PProfizi PProfizi self-assigned this Feb 10, 2025
@PProfizi PProfizi changed the title Only ask for review for operator updates on main branch Only ask integration_proxies for review for operator updates on main branch Feb 10, 2025
@PProfizi PProfizi requested a review from moe-ad February 10, 2025 15:07
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.52%. Comparing base (50d0208) to head (13178b3).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2068      +/-   ##
==========================================
+ Coverage   86.40%   86.52%   +0.11%     
==========================================
  Files          90       90              
  Lines       10233    10233              
==========================================
+ Hits         8842     8854      +12     
+ Misses       1391     1379      -12     

@PProfizi PProfizi merged commit 122ab41 into master Feb 10, 2025
46 checks passed
@PProfizi PProfizi deleted the ci/operator_update_review_only_on_main branch February 10, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants