Fix test after addition of Rotation result #2542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardopeixotocoelho
force-pushed
the
rpeixoto/fix_test_after_addition_rot
branch
from
6e655db to
b46e847
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2542 +/- ##
=======================================
Coverage 84.11% 84.11%
=======================================
Files 91 91
Lines 10706 10706
=======================================
Hits 9005 9005
Misses 1701 1701 |
…ixoto/fix_test_after_addition_rot
cbellot000
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the addition of rotation result to available results, the position of ENF result got shifted from 3rd position to 4th for the test:02-hdf5_serialize_and_read. This made the comparison happen on a different result which caused an error.
This PR changes the test so that we always look at the result ENF no matter its position on the result info.