fix: Options api rework #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 21, 2025 14:08
also implement ability for options to be mutually exclusive
github-actions
bot
added
documentation
for more information, see https://pre-commit.ci
refactor generation system to use handler classes
…into options-api-rework
|
This also required handling of "shared fields" across options. Shared fields are when multiple cards use the same field conceptually, but pydyna-keywords is designed that each field in each card is it's own object. The code generation did not account for that so I had to work that into this fix. I started to refactor the generation system around handler objects. It still isn't that straightforward but I think it's moving more in that direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #667
The implementation of options was a bit awkward. It still is, but this should be easier to follow now.
The main fix here is to make options with the same title/card index mutually exlcusive. Meaning when one such option is activated all other options are deactivated.
An example of this is the two options "TITLE" and "ID" of
*CONSTRAINED_BEAM_IN_SOLIDwhich have the same meaning.