Skip to content

Commit

Permalink
Merge branch 'main' into release/0.34
Browse files Browse the repository at this point in the history
  • Loading branch information
SMoraisAnsys committed Nov 29, 2024
2 parents a25ceb6 + 9c70077 commit 9cdc45d
Show file tree
Hide file tree
Showing 14 changed files with 457 additions and 125 deletions.
13 changes: 6 additions & 7 deletions .github/workflows/ci_cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ jobs:
needs: [smoke-tests]
runs-on: [ self-hosted, Linux, pyaedt ]
env:
ANSYSEM_ROOT242: '/ansys_inc/AnsysEM/v242/Linux64'
ANSYSEM_ROOT242: '/opt/AnsysEM/v242/Linux64'
ANS_NODEPCHECK: '1'
steps:
- name: Install Git and checkout project
Expand All @@ -304,12 +304,10 @@ jobs:

- name: Create Python venv
run: |
export LD_LIBRARY_PATH=${{ env.ANSYSEM_ROOT242 }}/common/mono/Linux64/lib64:${{ env.ANSYSEM_ROOT242 }}/Delcross:$LD_LIBRARY_PATH
python -m venv .venv
- name: Update pip
run: |
export LD_LIBRARY_PATH=${{ env.ANSYSEM_ROOT242 }}/common/mono/Linux64/lib64:${{ env.ANSYSEM_ROOT242 }}/Delcross:$LD_LIBRARY_PATH
. .venv/bin/activate
python -m pip install -U pip
Expand All @@ -322,18 +320,19 @@ jobs:

- name: Install PyAEDT main branch version with its test dependencies
run: |
export LD_LIBRARY_PATH=${{ env.ANSYSEM_ROOT242 }}/common/mono/Linux64/lib64:${{ env.ANSYSEM_ROOT242 }}/Delcross:$LD_LIBRARY_PATH
export LD_LIBRARY_PATH=${{ env.ANSYSEM_ROOT242 }}/common/mono/Linux64/lib64:$LD_LIBRARY_PATH
. .venv/bin/activate
pip install --no-cache-dir external/pyaedt[tests]
- name: Install PyEDB
run: |
export LD_LIBRARY_PATH=${{ env.ANSYSEM_ROOT242 }}/common/mono/Linux64/lib64:${{ env.ANSYSEM_ROOT242 }}/Delcross:$LD_LIBRARY_PATH
export LD_LIBRARY_PATH=${{ env.ANSYSEM_ROOT242 }}/common/mono/Linux64/lib64:$LD_LIBRARY_PATH
. .venv/bin/activate
python -m pip install .
- name: Install CI dependencies (e.g. vtk-osmesa)
run: |
export LD_LIBRARY_PATH=${{ env.ANSYSEM_ROOT242 }}/common/mono/Linux64/lib64:$LD_LIBRARY_PATH
. .venv/bin/activate
# Uninstall conflicting dependencies
pip uninstall --yes vtk
Expand All @@ -348,7 +347,7 @@ jobs:
retry_on: error
timeout_minutes: 50
command: |
export LD_LIBRARY_PATH=${{ env.ANSYSEM_ROOT242 }}/common/mono/Linux64/lib64:${{ env.ANSYSEM_ROOT242 }}/Delcross:$LD_LIBRARY_PATH
export LD_LIBRARY_PATH=${{ env.ANSYSEM_ROOT242 }}/common/mono/Linux64/lib64:$LD_LIBRARY_PATH
. .venv/bin/activate
pytest -n auto --dist loadfile --durations=50 -v external/pyaedt/tests/system/general/
Expand All @@ -361,7 +360,7 @@ jobs:
retry_on: error
timeout_minutes: 50
command: |
export LD_LIBRARY_PATH=${{ env.ANSYSEM_ROOT242 }}/common/mono/Linux64/lib64:${{ env.ANSYSEM_ROOT242 }}/Delcross:$LD_LIBRARY_PATH
export LD_LIBRARY_PATH=${{ env.ANSYSEM_ROOT242 }}/common/mono/Linux64/lib64:$LD_LIBRARY_PATH
. .venv/bin/activate
pytest --durations=50 -v external/pyaedt/tests/system/solvers
Expand Down
15 changes: 6 additions & 9 deletions doc/source/build_breaking_change.rst
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,11 @@ A temporary workaround was considered, which involved manually installing an old
`libssl1.1` library. While this allowed the use of `dotnetcore2`, it is **not recommended** as a
long-term solution for the following reasons:

- **Security risks**: Installing an older version of `libssl` introduces vulnerabilities, as it may
lack the latest security updates provided in the newer versions.
- **System instability**: Manually forcing an older version of `libssl` can lead to dependency
conflicts with other software packages that rely on newer versions of this library, potentially
causing further compatibility issues in the system.
- **Maintenance overhead**: Relying on deprecated or unsupported libraries increases the
complexity of future upgrades and system maintenance, making the environment harder to manage in the
long term.
- **Security risks**: Installing an older version of `libssl` introduces vulnerabilities, as it may lack the latest security updates provided in the newer versions.

- **System instability**: Manually forcing an older version of `libssl` can lead to dependency conflicts with other software packages that rely on newer versions of this library, potentially causing further compatibility issues in the system.

- **Maintenance overhead**: Relying on deprecated or unsupported libraries increases the complexity of future upgrades and system maintenance, making the environment harder to manage in the long term.

Impact
------
Expand All @@ -35,7 +32,7 @@ Microsoft documentation for `.NET` on Linux to ensure proper setup and compatibi
`Register Microsoft package repository <https://learn.microsoft.com/en-us/dotnet/core/install/linux-ubuntu#register-the-microsoft-package-repository>`_
and `Install .NET <https://learn.microsoft.com/en-us/dotnet/core/install/linux-ubuntu#install-net>`_.

.. note:: Ubuntu 22.04 and later versions
.. note::
Starting with Ubuntu 22.04, `.NET` is available in the official Ubuntu repository.
If you want to use the Microsoft package to install `.NET`, you can use the following
approach to *"demote"* the Ubuntu packages so that the Microsoft packages take precedence.
Expand Down
1 change: 1 addition & 0 deletions doc/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ def setup(app):
nbsphinx_thumbnails = {
"examples/use_configuration/pdn_analysis": "_static/thumbnails/101_getting_started.png",
"examples/use_configuration/serdes": "_static/thumbnails/101_getting_started.png",
"examples/use_configuration/pcb_dc_ir": "_static/thumbnails/101_getting_started.png",
"examples/use_configuration/import_stackup": "_static/thumbnails/101_getting_started.png",
"examples/use_configuration/import_material": "_static/thumbnails/101_getting_started.png",
"examples/use_configuration/import_ports": "_static/thumbnails/101_getting_started.png",
Expand Down
4 changes: 3 additions & 1 deletion examples/use_configuration/import_sources.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@
voltage_source = {
"name": "V_SOURCE_5V",
"reference_designator": "U4",
"type": "circuit",
"type": "voltage",
"magnitude": 1,
"positive_terminal": {"net": "5V"},
"negative_terminal": {"net": "GND"},
}
Expand All @@ -65,6 +66,7 @@
"name": "I_CURRENT_1A",
"reference_designator": "J5",
"type": "current",
"magnitude": 10,
"positive_terminal": {"pin": "15"},
"negative_terminal": {"pin": "14"},
}
Expand Down
1 change: 1 addition & 0 deletions examples/use_configuration/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ End-to-end workflow

pdn_analysis.py
serdes.py
pcb_dc_ir.py

Step explanation
-------------------------
Expand Down
Loading

0 comments on commit 9cdc45d

Please sign in to comment.