-
Notifications
You must be signed in to change notification settings - Fork 134
feat: post1
submodule (1/2) - disabled due to merging branch issue
#3983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideThis PR automates the generation of the Class Diagram: New
|
Change | Details | Files |
---|---|---|
Updated core commands import and Post1Commands composition |
|
src/ansys/mapdl/core/commands.py |
Generated new post1 command modules |
|
src/ansys/mapdl/core/_commands/post1/animation.py src/ansys/mapdl/core/_commands/post1/controls.py src/ansys/mapdl/core/_commands/post1/element_table.py src/ansys/mapdl/core/_commands/post1/_fatigue.py src/ansys/mapdl/core/_commands/post1/load_case_calculations.py src/ansys/mapdl/core/_commands/post1/listing.py src/ansys/mapdl/core/_commands/post1/failure_criteria.py src/ansys/mapdl/core/_commands/post1/_special_purpose.py src/ansys/mapdl/core/_commands/post1/__init__.py |
Added Sphinx documentation for post1 commands |
|
doc/source/mapdl_commands/post1/animation.rst doc/source/mapdl_commands/post1/controls.rst doc/source/mapdl_commands/post1/element_table.rst doc/source/mapdl_commands/post1/failure_criteria.rst doc/source/mapdl_commands/post1/listing.rst doc/source/mapdl_commands/post1/magnetics_calc.rst doc/source/mapdl_commands/post1/setup.rst doc/source/mapdl_commands/post1/special.rst doc/source/mapdl_commands/post1/load_case_calculations.rst doc/source/mapdl_commands/post1/_fatigue.rst doc/source/mapdl_commands/post1/_special_purpose.rst doc/source/mapdl_commands/post1/index.rst |
Cleaned up legacy underscore subpackage |
|
src/ansys/mapdl/core/_commands/post1_/* doc/source/mapdl_commands/post1/load_case.rst |
Updated project configuration |
|
doc/styles/config/vocabularies/ANSYS/accept.txt |
Tips and commands
Interacting with Sourcery
- Trigger a new review: Comment
@sourcery-ai review
on the pull request. - Continue discussions: Reply directly to Sourcery's review comments.
- Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with@sourcery-ai issue
to create an issue from it. - Generate a pull request title: Write
@sourcery-ai
anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title
on the pull request to (re-)generate the title at any time. - Generate a pull request summary: Write
@sourcery-ai summary
anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment@sourcery-ai summary
on the pull request to
(re-)generate the summary at any time. - Generate reviewer's guide: Comment
@sourcery-ai guide
on the pull
request to (re-)generate the reviewer's guide at any time. - Resolve all Sourcery comments: Comment
@sourcery-ai resolve
on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore. - Dismiss all Sourcery reviews: Comment
@sourcery-ai dismiss
on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review
to trigger a new review!
Customizing Your Experience
Access your dashboard to:
- Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others. - Change the review language.
- Add, remove or edit custom review instructions.
- Adjust other review settings.
Getting Help
- Contact our support team for questions or feedback.
- Visit our documentation for detailed guides and information.
- Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @clatapie - I've reviewed your changes - here's some feedback:
- Rather than manually listing every new post1 submodule in
commands.py
, consider using dynamic discovery or a registration helper to auto-import modules and reduce boilerplate maintenance. - The deep multiple‐inheritance in
Post1Commands
is hard to follow—group related commands into cohesive mixin classes or use composition to simplify the class hierarchy. - Since these files are auto-generated, integrate the conversion tool into CI (e.g. a regen step) so updates stay in sync and avoid merge conflicts with stale generated code.
Here's what I looked at during the review
- 🟡 General issues: 20 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3983 +/- ##
==========================================
- Coverage 89.12% 89.11% -0.02%
==========================================
Files 187 190 +3
Lines 14970 15008 +38
==========================================
+ Hits 13342 13374 +32
- Misses 1628 1634 +6 🚀 New features to boost your workflow:
|
… into feat/post1_submodule
This PR is ready for review @germa89. As mentioned in the PR description, another PR will follow this one for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review in progress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Very minor comments.
This PR cannot be merged as it would be merged into |
All the comments have been addressed. |
post1
submodule (1/2)post1
submodule (1/2) - disabled due to merging branch issue
You could have just changed the target of the PR. |
Description
This PR follows the PyConverter-XML2Py integration plan to automate the PyMAPDL_commands documentation.
The changes have been generated using pyconverter-xml2py and more specifically mapdl-cmd-conv.
This PR focus on the
post1
submodule,part 1
. A follow-up PR will come right after with part 2.You can check the mapdl-cmd-conv documentation to have a look at the output of each submodules.
Pinging @ansys/pymapdl-developers for visibility. Feel free to provide any feedback on the way the docstrings and the source code generation are handled.
Issue linked
This PR is meant to be merged within the feat/main_commands branch. The latter will gather all the submodule changes, one by one, prior to be merged to the main branch.
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)Summary by Sourcery
Generate and integrate the
post1
submodule as part one of the XML-to-Python conversion, providing a full suite of APDL postprocessing command wrappers and corresponding documentation.New Features:
post1
submodule with automated command wrappers for postprocessing (Animation, Controls, ElementTable, Fatigue, Load Case Calculations, Listing, SpecialPurpose, FailureCriteria).Enhancements:
Post1Commands
to inherit from newpost1
classes instead of legacy implementations.Documentation:
post1
commands underdoc/source/mapdl_commands/post1
.