Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of PYPRIMEMESH_LAUNCH_CONTAINER environment variable during launch #549

Merged
merged 5 commits into from
Jul 19, 2023

Conversation

ninad-kamat
Copy link
Contributor

Fixes #475 .

This change also adds functionality to launch containers in parallel

@ninad-kamat ninad-kamat self-assigned this Jul 17, 2023
@github-actions github-actions bot added the bug Something isn't working label Jul 17, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #549 (58843b3) into main (1c6f118) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
+ Coverage   77.39%   77.43%   +0.04%     
==========================================
  Files          31       31              
  Lines        2199     2203       +4     
==========================================
+ Hits         1702     1706       +4     
  Misses        497      497              
Impacted Files Coverage Δ
src/ansys/meshing/prime/internals/launcher.py 28.15% <100.00%> (ø)
src/ansys/meshing/prime/internals/utils.py 65.03% <100.00%> (+0.87%) ⬆️

Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor comment.

src/ansys/meshing/prime/internals/launcher.py Outdated Show resolved Hide resolved
@ninad-kamat ninad-kamat merged commit 53a704f into main Jul 19, 2023
21 checks passed
@ninad-kamat ninad-kamat deleted the fix/container_env_var branch July 19, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PYPRIMEMESH_LAUNCH_CONTAINER environment variable is not being checked properly.
3 participants