Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new example 000 #626

Merged
merged 8 commits into from
Nov 29, 2023
Merged

new example 000 #626

merged 8 commits into from
Nov 29, 2023

Conversation

agvarghe
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the enhancement New features or code improvements label Oct 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b59d142) 76.02% compared to head (e6a729d) 76.02%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #626   +/-   ##
=======================================
  Coverage   76.02%   76.02%           
=======================================
  Files          32       32           
  Lines        2273     2273           
=======================================
  Hits         1728     1728           
  Misses        545      545

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

waltersma
waltersma requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@waltersma waltersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples need fixing.

@agvarghe agvarghe changed the title new example 010 new example 001 Oct 25, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 25, 2023
@agvarghe agvarghe force-pushed the feat/simple_example branch 3 times, most recently from 0ed1176 to ab1c66a Compare October 25, 2023 06:01
@agvarghe agvarghe force-pushed the feat/simple_example branch 4 times, most recently from 6ce82bf to ade6ef9 Compare October 27, 2023 07:24
@agvarghe agvarghe force-pushed the feat/simple_example branch 6 times, most recently from b9e0cfb to c3eada1 Compare November 6, 2023 09:59
@waltersma
Copy link
Contributor

@ninad-kamat @agvarghe for the cdb import we may want to delay this part of the example until this issue is resolved.

@agvarghe
Copy link
Contributor Author

@ninad-kamat @agvarghe for the cdb import we may want to delay this part of the example until this issue is resolved.

sure, i will modify the file and remove the section talking about cdb import

@prajaktmahajan prajaktmahajan merged commit 5eea674 into main Nov 29, 2023
25 checks passed
@prajaktmahajan prajaktmahajan deleted the feat/simple_example branch November 29, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltersma waltersma waltersma approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agvarghe @codecov-commenter @waltersma @prajaktmahajan