-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add description for Radio #1064
feat: add description for Radio #1064
Conversation
docs: add radio description docs
docs: add RadioGroup description doc
457af9d
to
1f95e79
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1064 +/- ##
==========================================
+ Coverage 89.55% 89.83% +0.28%
==========================================
Files 144 144
Lines 3321 3315 -6
Branches 815 812 -3
==========================================
+ Hits 2974 2978 +4
+ Misses 293 283 -10
Partials 54 54 ☔ View full report in Codecov by Sentry. |
src/Radio/index.less
Outdated
opacity: @radio-item-description; | ||
color: @COLOR_TEXT_PRIMARY; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是不是可以用这个颜色?
src/Radio/variable.less
Outdated
@@ -19,3 +19,6 @@ | |||
|
|||
/* color | disabled状态背景色 */ | |||
@radio-disabled-background: @COLOR_GREY_CARD; | |||
|
|||
/* radio 选项描述透明度 */ | |||
@radio-item-description: 0.6; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个删掉吧。 用 @COLOR_TEXT_ASSIST;
src/Radio/index.axml.tsx
Outdated
@@ -65,5 +72,14 @@ export default ( | |||
</View> | |||
</View> | |||
</Label> | |||
{typeof description === 'string' && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不要用 typeof , 这个在微信不支持。 用 description && 就可以了
支持这个 issue 👉 #1042