Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: semantic font size variables #6565

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guoyunhe
Copy link
Contributor

@guoyunhe guoyunhe commented Mar 3, 2024

将原本的 10 个非语义化的字体大小变量,合并为 5 个语义化的字体大小变量。

:root {
  --adm-font-size-1: 9px;
  --adm-font-size-2: 10px;
  // 合并为
  --adm-font-size-tiny: var(--adm-font-size-1);

  --adm-font-size-3: 11px;
  --adm-font-size-4: 12px;
  // 合并为
  --adm-font-size-small: var(--adm-font-size-3);

  --adm-font-size-5: 13px;
  --adm-font-size-6: 14px;
  // 合并为
  --adm-font-size-main: var(--adm-font-size-5);

  --adm-font-size-7: 15px;
  --adm-font-size-8: 16px;
  // 合并为
  --adm-font-size-large: var(--adm-font-size-8);

  --adm-font-size-9: 17px;
  --adm-font-size-10: 18px;
  // 合并为
  --adm-font-size-huge: var(--adm-font-size-10);
}

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.34%. Comparing base (784eff5) to head (b63cdce).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6565   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files         318      318           
  Lines        6910     6910           
  Branches     1729     1729           
=======================================
  Hits         6381     6381           
  Misses        493      493           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Mar 3, 2024

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6565.surge.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant