Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use unified github action yml #65

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

Layouwen
Copy link
Member

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.17%. Comparing base (d687435) to head (84f9b2b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   79.17%   79.17%           
=======================================
  Files           1        1           
  Lines         317      317           
  Branches       93       88    -5     
=======================================
  Hits          251      251           
  Misses         65       65           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Layouwen
Copy link
Member Author

@afc163 CR~

},
},
"exclude": [
"./bench"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥 exclude 掉?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

  1. 目前的 ci 流程是会走 tsc noEmit 进行编译测试, 但是包含了 bench 的测试用例代码.
  2. bench 中依赖了 es 的产物, 目前 ci 是没有缓存 compile 的构建产物. 导致 tsc 会过不了
  3. 我翻了一下 yml 的 git 修改记录, npm run bench 这个一直没有在 ci 中, 并且 npm run bench 是直接跑 .ts 的, 不需要tsc 先编译一次

所以我这边就把 bench 目录 exclude 了

@afc163 afc163 merged commit dbe07d9 into ant-design:master Aug 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants