Feature/bubble footer enhancement #638

Lliuxs · 2025-03-21T06:56:05Z

🤔 This is a ...

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.
Bubble 组件 footer 无法获取消息上下文 #594

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://x.ant.design/changelog

Language	Changelog
🇺🇸 English
🇨🇳 Chinese

close ant-design#590

* docs: fix attachments docs * docs: fix attachments en-us doc

coderabbitai · 2025-03-21T06:56:13Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-03-21T06:56:18Z

petercat-assistant · 2025-03-21T06:56:20Z

Walkthrough

This pull request enhances the Bubble component by adding a new feature to support dynamic footer content. The footer can now be a static React node or a function that receives the content as a parameter. This change also includes updates to the documentation and test cases to reflect the new functionality.

Changes

Files	Summary
components/attachments/index.en-US.md, components/attachments/index.zh-CN.md	Updated the `onRemove` property type description to include `Promise`.
components/bubble/Bubble.tsx	Enhanced the Bubble component to support dynamic footer content.
components/bubble/tests/index.test.tsx	Added test cases for the new footer functionality in the Bubble component.
components/bubble/demo/header-and-footer.tsx	Updated demo to showcase the new footer functionality.
components/bubble/index.en-US.md, components/bubble/index.zh-CN.md	Updated documentation to reflect changes in footer property.
components/bubble/interface.ts	Modified the interface to support the new footer type.
components/thought-chain/tests/index.test.tsx	Added a test case for controlled mode in ThoughtChain component.
components/thought-chain/hooks/useCollapsible.ts	Refactored to use `useMergedState` with additional options.

petercat-assistant · 2025-03-21T06:56:23Z

components/bubble/Bubble.tsx

@@ -173,7 +182,8 @@ const Bubble: React.ForwardRefRenderFunction<BubbleRef, BubbleProps> = (props, r
              ...styles.footer,
            }}
          >
-            {footer}
+            {/* {footerNode} */}
+            {typeof footer === 'function' ? footer(mergedContent as string) : footer}


Ensure that the footer function handles all possible content types correctly to avoid runtime errors.

kimteayon · 2025-03-21T09:36:23Z

components/bubble/demo/header-and-footer.tsx

 import React from 'react';

 const App: React.FC = () => {
  const { token } = theme.useToken();

+  // 豆包中生成的图片也是不支持复制的 如果期望的是复制待md格式的内容?


无关注释需要删除

kimteayon · 2025-03-21T09:36:37Z

components/bubble/demo/header-and-footer.tsx

        <Space size={token.paddingXXS}>
          <Button color="default" variant="text" size="small" icon={<SyncOutlined />} />
-          <Button color="default" variant="text" size="small" icon={<CopyOutlined />} />
+          <Button
+            // onClick={() => console.log('Copy message:', messageContext.content)}


无关注释需要删除

kimteayon · 2025-03-21T09:37:38Z

components/bubble/Bubble.tsx

@@ -161,6 +169,7 @@ const Bubble: React.ForwardRefRenderFunction<BubbleRef, BubbleProps> = (props, r
          </div>
        )}
        {fullContent}
+        {/* {footerNode && ( */}


多余代码注释需要删除

kimteayon · 2025-03-21T09:40:34Z

components/bubble/Bubble.tsx

+  // } else {
+  //   footerNode = footer;
+  // }
+  // if (header || footerNode) {


代码注释需要删除

codecov · 2025-03-24T05:23:56Z

Bundle Report

Bundle size has no change ✅

codecov · 2025-03-24T05:25:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (e3774b9) to head (2da4f2b).

Additional details and impacted files

@@             Coverage Diff             @@
##           feature     #638      +/-   ##
===========================================
+ Coverage    91.81%   91.88%   +0.07%     
===========================================
  Files           67       67              
  Lines         1466     1467       +1     
  Branches       388      388              
===========================================
+ Hits          1346     1348       +2     
+ Misses         120      119       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

whitexie and others added 3 commits March 19, 2025 20:30

fix(thought-chain): controlled mode not working

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

bbb2fae

close ant-design#590

feat: bubble_footer_enhancement

Loading
Loading status checks…

ff2c36f

petercat-assistant bot reviewed Mar 21, 2025

View reviewed changes

Merge branch 'feature' into feature/bubble_footer_enhancement

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

6806264

kimteayon reviewed Mar 21, 2025

View reviewed changes

feat: bubble_footer_enhancement

Loading
Loading status checks…

2da4f2b

Lliuxs requested a review from kimteayon March 23, 2025 03:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/bubble footer enhancement #638

Feature/bubble footer enhancement #638

Lliuxs commented Mar 21, 2025

coderabbitai bot commented Mar 21, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Mar 21, 2025 •

edited

Loading

petercat-assistant bot commented Mar 21, 2025

petercat-assistant bot Mar 21, 2025

Lliuxs Mar 21, 2025

kimteayon Mar 21, 2025

kimteayon Mar 21, 2025

kimteayon Mar 21, 2025

kimteayon Mar 21, 2025

codecov bot commented Mar 24, 2025 •

edited

Loading

codecov bot commented Mar 24, 2025

Feature/bubble footer enhancement #638

Are you sure you want to change the base?

Feature/bubble footer enhancement #638

Conversation

Lliuxs commented Mar 21, 2025

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

coderabbitai bot commented Mar 21, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Mar 21, 2025 • edited Loading

petercat-assistant bot commented Mar 21, 2025

Walkthrough

Changes

petercat-assistant bot Mar 21, 2025

Choose a reason for hiding this comment

Lliuxs Mar 21, 2025

Choose a reason for hiding this comment

kimteayon Mar 21, 2025

Choose a reason for hiding this comment

kimteayon Mar 21, 2025

Choose a reason for hiding this comment

kimteayon Mar 21, 2025

Choose a reason for hiding this comment

kimteayon Mar 21, 2025

Choose a reason for hiding this comment

codecov bot commented Mar 24, 2025 • edited Loading

Bundle Report

codecov bot commented Mar 24, 2025

Codecov Report

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Mar 21, 2025 •

edited

Loading

codecov bot commented Mar 24, 2025 •

edited

Loading