Skip to content

Commit

Permalink
minor tweeks to PR template
Browse files Browse the repository at this point in the history
  • Loading branch information
SamuelHall700 committed Apr 27, 2023
1 parent a5cdc60 commit e4571cf
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ This includes a collection of test files which should be run according to which
- [ ] I have commented my code, particularly in hard-to-understand areas.
- [ ] I have updated the documentation of the codebase where required.
- [ ] My changes generate no new warnings.
- [ ] My PR has been made to the `intergration_testing` branch (**DO NOT SUBMIT A PR TO MAIN**)
- [ ] My PR has been made to the `0.2.x` branch (**DO NOT SUBMIT A PR TO MAIN**)


Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ Evidence that all the required regression tests have passed needs to be submitte
Pull requests will not be accepted unless all required regression tests pass.

## Mesh Construction

| **Files altered** | **Tests** |
|----------------------------|---------------------------------------|
| `mesh_builder.py` | `tests/regression_tests/test_mesh.py` |
Expand All @@ -21,7 +20,6 @@ Pull requests will not be accepted unless all required regression tests pass.
| | |



## Vessel Performance Modelling
| **Files altered** | **Tests** |
|-------------------------------------|-----------------------------------------|
Expand All @@ -32,15 +30,13 @@ Pull requests will not be accepted unless all required regression tests pass.


## Route Planning

| **Files altered** | **Tests** |
|----------------------|-----------------------------------------------------|
| `crossing.py` | `tests/regression_tests/test_routes_dijkstra.py` |
| `route_planner.py` | `tests/regression_tests/test_routes_smoothed.py` |
| | |



## Testing files
Some updates to PolarRoute may result in changes to meshes calculated in our tests suite (*such as adding additional attributes to the cellbox object*). These changes will cause the test suite to fail, though the mode of failure should be predictable.

Expand Down

0 comments on commit e4571cf

Please sign in to comment.