Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VirtualCluster] Dashboard supports CRUD of virtual clusters [1/N] #418

Merged
merged 11 commits into from
Dec 18, 2024

Conversation

Chong-Li
Copy link
Collaborator

Why are these changes needed?

This PR provides http APIs at the dashboard.

Related issue number

#417

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Chong-Li Chong-Li requested a review from wumuzi520 December 12, 2024 10:02
@Chong-Li Chong-Li marked this pull request as draft December 12, 2024 10:03
@Chong-Li Chong-Li marked this pull request as ready for review December 14, 2024 10:56
@Chong-Li Chong-Li requested a review from raulchen as a code owner December 14, 2024 10:56
@antfin-oss antfin-oss removed the request for review from raulchen December 16, 2024 12:05
@Chong-Li Chong-Li force-pushed the virtual_cluster_api branch from e5ed6f0 to 32f38d2 Compare December 17, 2024 09:02
Copy link
Collaborator

@wumuzi520 wumuzi520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants