Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14/N][VirtualCluster] Raylet only subscribe mixed cluster data. #431

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

wumuzi520
Copy link
Collaborator

@wumuzi520 wumuzi520 commented Dec 22, 2024

Why are these changes needed?

This PR is 14/N implementation of the VirtualCluster (see issue #409) , Raylet only subscribe mixed cluster data.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@wumuzi520 wumuzi520 requested review from Chong-Li and xsuler December 22, 2024 12:49
@wumuzi520 wumuzi520 changed the title [15/N][VirtualCluster] Fix subscribe mixed cluster data [14/N][VirtualCluster] Fix subscribe mixed cluster data Dec 22, 2024
@wumuzi520 wumuzi520 changed the title [14/N][VirtualCluster] Fix subscribe mixed cluster data [14/N][VirtualCluster] Raylet only subscribe mixed cluster data. Dec 23, 2024
Copy link
Collaborator

@xsuler xsuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wumuzi520 wumuzi520 merged commit bd65b46 into main Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants