Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18/N][VirtualCluster] Handle job finished event in gcs virtual cluster manager #436

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

xsuler
Copy link
Collaborator

@xsuler xsuler commented Dec 24, 2024

Why are these changes needed?

This PR is 18/N implementation of the VirtualCluster (see issue #409) . Handle job finished event in gcs virtual cluster manager.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@xsuler xsuler requested a review from wumuzi520 December 24, 2024 08:01
@xsuler xsuler self-assigned this Dec 24, 2024
@xsuler xsuler force-pushed the dev-sl branch 3 times, most recently from a15a8cc to af4f824 Compare December 24, 2024 08:31
Copy link
Collaborator

@wumuzi520 wumuzi520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: sule <[email protected]>
@xsuler xsuler merged commit 700015d into main Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants