forked from ray-project/ray
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ray data virtual cluster test #453
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
wumuzi520
reviewed
Jan 9, 2025
wumuzi520
reviewed
Jan 9, 2025
print( | ||
f"Driver detected parallelism: {res}, expect[{i}]: {expected_parallelism[i]}" | ||
) | ||
wait_for_condition( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert ray.get(signal_actor.data.remote())
== expected_parallelism[i]
wumuzi520
reviewed
Jan 9, 2025
wumuzi520
reviewed
Jan 9, 2025
wumuzi520
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: NKcqx <[email protected]>
Signed-off-by: NKcqx <[email protected]>
wumuzi520
pushed a commit
that referenced
this pull request
Jan 9, 2025
* ray.nodes fetch only the virtual cluster nodes Signed-off-by: NKcqx <[email protected]> * pass UT Signed-off-by: NKcqx <[email protected]> * support cluster_resources split virtual_cluster Signed-off-by: NKcqx <[email protected]> * available_resources support virtual_cluster Signed-off-by: NKcqx <[email protected]> * job only get virtual cluster data Signed-off-by: NKcqx <[email protected]> * fix ut Signed-off-by: NKcqx <[email protected]> * rm outdated warning Signed-off-by: NKcqx <[email protected]> * assert job in certain virtual cluster Signed-off-by: NKcqx <[email protected]> * pass UT Signed-off-by: NKcqx <[email protected]> * add UT Signed-off-by: NKcqx <[email protected]> * lint codes Signed-off-by: NKcqx <[email protected]> * add barrier for sync job progress Signed-off-by: NKcqx <[email protected]> * more comments Signed-off-by: NKcqx <[email protected]> --------- Signed-off-by: NKcqx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
#409
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.