remove unuseful log for ut and ft (#303)

Signed-off-by: jinjiabao.jjb <[email protected]>
antgroup · Jan 9, 2025 · e87defc · e87defc
1 parent f7acef7
commit e87defc
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -262,6 +262,7 @@ endif ()
 
 # tests
 if (ENABLE_TESTS)
+    target_compile_definitions(vsag PRIVATE ENABLE_TESTS)
     add_subdirectory (tests)
 endif ()
 

diff --git a/src/index/diskann.cpp b/src/index/diskann.cpp
@@ -300,7 +300,9 @@ DiskANN::knn_search(const DatasetPtr& query,
                     int64_t k,
                     const std::string& parameters,
                     const std::function<bool(int64_t)>& filter) const {
+#ifndef ENABLE_TESTS
     SlowTaskTimer t("diskann knnsearch", 200);
+#endif
 
     // cannot perform search on empty index
     if (empty_index_) {
@@ -461,7 +463,9 @@ DiskANN::range_search(const DatasetPtr& query,
                       const std::string& parameters,
                       const std::function<bool(int64_t)>& filter,
                       int64_t limited_size) const {
+#ifndef ENABLE_TESTS
     SlowTaskTimer t("diskann rangesearch", 200);
+#endif
 
     // cannot perform search on empty index
     if (empty_index_) {

diff --git a/src/index/hnsw.cpp b/src/index/hnsw.cpp
@@ -141,7 +141,9 @@ HNSW::build(const DatasetPtr& base) {
 
 tl::expected<std::vector<int64_t>, Error>
 HNSW::add(const DatasetPtr& base) {
+#ifndef ENABLE_TESTS
     SlowTaskTimer t("hnsw add", 20);
+#endif
     if (use_static_) {
         LOG_ERROR_AND_RETURNS(ErrorType::UNSUPPORTED_INDEX_OPERATION,
                               "static index does not support add");
@@ -192,8 +194,9 @@ HNSW::knn_search(const DatasetPtr& query,
                  int64_t k,
                  const std::string& parameters,
                  BaseFilterFunctor* filter_ptr) const {
+#ifndef ENABLE_TESTS
     SlowTaskTimer t_total("hnsw knnsearch", 20);
-
+#endif
     try {
         // cannot perform search on empty index
         if (empty_index_) {
@@ -315,8 +318,9 @@ HNSW::range_search(const DatasetPtr& query,
                    const std::string& parameters,
                    BaseFilterFunctor* filter_ptr,
                    int64_t limited_size) const {
+#ifndef ENABLE_TESTS
     SlowTaskTimer t("hnsw rangesearch", 20);
-
+#endif
     try {
         // cannot perform search on empty index
         if (empty_index_) {
@@ -615,8 +619,10 @@ HNSW::update_id(int64_t old_id, int64_t new_id) {
         std::reinterpret_pointer_cast<hnswlib::HierarchicalNSW>(alg_hnsw_)->updateLabel(old_id,
                                                                                         new_id);
     } catch (const std::runtime_error& e) {
+#ifndef ENABLE_TESTS
         logger::warn(
             "update error for replace old_id {} to new_id {}: {}", old_id, new_id, e.what());
+#endif
         return false;
     }
 
@@ -641,7 +647,9 @@ HNSW::update_vector(int64_t id, const DatasetPtr& new_base, bool need_fine_tune)
         std::reinterpret_pointer_cast<hnswlib::HierarchicalNSW>(alg_hnsw_)->updateVector(
             id, new_base_vec);
     } catch (const std::runtime_error& e) {
+#ifndef ENABLE_TESTS
         logger::warn("update error for replace vector of id {}: {}", id, e.what());
+#endif
         return false;
     }
 

diff --git a/tests/test_random_allocator.cpp b/tests/test_random_allocator.cpp
@@ -18,8 +18,10 @@
 
 #include "fixtures/random_allocator.h"
 #include "vsag//factory.h"
+#include "vsag/options.h"
 
 TEST_CASE("Random Alocator Test", "[ft][hnsw]") {
+    vsag::Options::Instance().logger()->SetLevel(vsag::Logger::Level::kOFF);
     fixtures::RandomAllocator allocator;
 
     auto paramesters = R"(