Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce vsag::Engine to manage resource instead origin vsag::Factory #203

Closed
LHT129 opened this issue Dec 10, 2024 · 0 comments
Closed
Assignees
Labels
kind/feature New feature or request

Comments

@LHT129
Copy link
Collaborator

LHT129 commented Dec 10, 2024

Regarding the management of Allocator, we are currently quite confused, especially in various special scenarios, such as static global default allocator, multiple indexes sharing one allocator, etc.

Therefore, we plan to introduce vasg::Engine, a new data structure, to manage resources such as allocator, thread pools, etc. Index generation can only be completed by vasg::Engine, so that we can ensure that all resources are valid before the vsag::Engine shutdown, and the resources sharing problems can also be solved very well.

Of course, the resources required for vasg::Engine initialization can be imported from outside. The default resource implementation can be provided by vsag if the resource is not imported external.

The following PR will solve this problem:
#194
#209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants