implement of the engine and rewrite factory #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LHT129
force-pushed
the
engine
branch
6 times, most recently
from
d42b997 to
e150eaf
Compare
LHT129
force-pushed
the
engine
branch
5 times, most recently
from
e9758e4 to
822e77c
Compare
LHT129
requested review from
inabao,
wxyucs,
ShawnShawnYou and
jiaweizone
as code owners
LHT129
changed the title
jiaweizone
reviewed
Dec 15, 2024
| @@ -36,7 +36,7 @@ class MemoryIO : public BasicIO<MemoryIO> { | |||
| } | |||
|
|
|||
| MemoryIO(const JsonType& io_param, const IndexCommonParam& common_param) | |||
| : allocator_(common_param.allocator_) { | |||
| : allocator_(common_param.allocator_.get()) { | |||
There was a problem hiding this comment.
the MemoryIO's lifetime is shorter than Index, so only raw pointer is enough
LHT129
force-pushed
the
engine
branch
2 times, most recently
from
58c1a5e to
2ed3275
Compare
LHT129
force-pushed
the
engine
branch
3 times, most recently
from
3006049 to
b1445c9
Compare
inabao
reviewed
Dec 19, 2024
include/vsag/engine.h
Outdated
|
|
||
| tl::expected<std::shared_ptr<Index>, Error> | ||
| CreateIndex(const std::string& name, const std::string& parameters); | ||
|
|
||
| // tl::expected<DatasetPtr, Error> | ||
| // CreateDataset(); | ||
|
|
There was a problem hiding this comment.
delete unnecessary modifications
LHT129
force-pushed
the
engine
branch
2 times, most recently
from
0aad381 to
48c7871
Compare
- allocator shared_ptr hold in Index and Dataset - the allocator ptr always point to SafeAllocator - allocator ptr is used inner index - only Engine/Resource can create Allocator Object Signed-off-by: LHT129 <[email protected]>
inabao
reviewed
Dec 20, 2024
| #include "index/hnsw_zparameters.h" | ||
| #include "index/index_common_param.h" | ||
| #include "vsag/vsag.h" | ||
| #include "ThreadPool.h" |
ShawnShawnYou
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #203