improve the preformance for hgraph bulid & add #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LHT129
commented
Dec 13, 2024
LHT129
commented
- avx512 simd optimization
- memory_block_io optimization
LHT129
added
the
kind/improvement
inabao
reviewed
Dec 13, 2024
src/io/memory_block_io.h
Outdated
| @@ -37,10 +37,17 @@ class MemoryBlockIO : public BasicIO<MemoryBlockIO> { | |||
| public: | |||
| explicit MemoryBlockIO(Allocator* allocator, uint64_t block_size = DEFAULT_BLOCK_SIZE) | |||
| : block_size_(block_size), allocator_(allocator), blocks_(0, allocator) { | |||
| block_bit_ = 0; | |||
| while (block_size_ > 0) { | |||
| block_size_ >>= 1; | |||
There was a problem hiding this comment.
will block_size_ be set to 0?
| return blocks_[block_no] + block_off; | ||
| } | ||
|
|
||
| [[nodiscard]] inline bool | ||
| check_in_one_block(uint64_t off1, uint64_t off2) const { | ||
| return (off1 / block_size_) == (off2 / block_size_); | ||
| return (off1 ^ off2) < block_size_; |
There was a problem hiding this comment.
block_size_ here is equal to 0
src/io/memory_block_io.h
Outdated
| block_bit_ += 1; | ||
| } | ||
| block_bit_ -= 1; | ||
| in_block_mask_ = (1ULL << block_bit_) - 1; |
There was a problem hiding this comment.
Will we constrain the size of the block size to be a power of 2.
There was a problem hiding this comment.
if not will round down
LHT129
force-pushed
the
improve
branch
2 times, most recently
from
58e0ad7 to
c4d1b30
Compare
jiaweizone
reviewed
Dec 14, 2024
src/io/memory_block_io.h
Outdated
| if (io_param.contains(BLOCK_IO_BLOCK_SIZE_KEY)) { | ||
| this->block_size_ = | ||
| io_param[BLOCK_IO_BLOCK_SIZE_KEY]; // TODO(LHT): trans str to uint64_t | ||
| } | ||
| this->update_by_block_size(); |
There was a problem hiding this comment.
we have default block size value
There was a problem hiding this comment.
yes, but L44 will invoke update_by_block_size()
src/io/memory_block_io.h
Outdated
| @@ -109,14 +123,18 @@ class MemoryBlockIO : public BasicIO<MemoryBlockIO> { | |||
| Allocator* const allocator_{nullptr}; | |||
|
|
|||
| static const uint64_t DEFAULT_BLOCK_SIZE = 128 * 1024 * 1024; // 128MB | |||
|
|
|||
| uint64_t block_bit_ = 27; | |||
There was a problem hiding this comment.
block_bits = 27 corresponds to a DEFAULT_BLOCK_SIZE of 128MB. Should we also define a corresponding DEFAULT_BLOCK_BITS = 27 here ?
src/simd/avx512.cpp
Outdated
| @@ -16,6 +16,7 @@ | |||
| #include <immintrin.h> | |||
|
|
|||
| #include <cmath> | |||
| #include <iostream> | |||
There was a problem hiding this comment.
remove unused header file
ShawnShawnYou
approved these changes
Dec 15, 2024
- avx512 simd optimization - memory_block_io optimization Signed-off-by: LHT129 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.