Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support inserting and querying vectors with nan values #248

Closed
wants to merge 7 commits into from

Conversation

inabao
Copy link
Collaborator

@inabao inabao commented Dec 23, 2024

No description provided.

@inabao inabao self-assigned this Dec 23, 2024
@wxyucs wxyucs added kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) version/0.12 module/testing labels Dec 24, 2024
jinjiabao.jjb added 3 commits December 25, 2024 14:52
Signed-off-by: jinjiabao.jjb <[email protected]>
Signed-off-by: jinjiabao.jjb <[email protected]>
@inabao inabao force-pushed the add-tests-for-nan-vector branch from d472ea2 to d323e8b Compare December 25, 2024 07:13
jinjiabao.jjb added 2 commits December 25, 2024 15:14
Signed-off-by: jinjiabao.jjb <[email protected]>
Signed-off-by: jinjiabao.jjb <[email protected]>
@inabao inabao changed the title add test for inserting and querying vectors with nan values support inserting and querying vectors with nan values Dec 26, 2024
tests/test_index.cpp Outdated Show resolved Hide resolved
tests/fixtures/test_dataset.h Show resolved Hide resolved
tests/fixtures/test_dataset.h Outdated Show resolved Hide resolved
Signed-off-by: jinjiabao.jjb <[email protected]>
Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: jinjiabao.jjb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) module/testing size/L version/0.13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants