Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update makefile and remove outdated benchs directory #270

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

wxyucs
Copy link
Collaborator

@wxyucs wxyucs commented Dec 27, 2024

the output after change:

Usage: make <target>

Targets:
help:                    ## Show the help.
##
## ================ development ================
debug:                   ## Build vsag with debug options.
test:                    ## Build and run unit tests.
asan:                    ## Build with AddressSanitizer option.
test_asan: asan          ## Run unit tests with AddressSanitizer option.
tsan:                    ## Build with ThreadSanitizer option.
test_tsan: tsan          ## Run unit tests with ThreadSanitizer option.
clean:                   ## Clear build/ directory.
##
## ================ integration ================
fmt:                     ## Format codes.
cov:                     ## Build unit tests with code coverage enabled.
test_parallel: debug     ## Run all tests parallel (used in CI).
test_asan_parallel: asan ## Run unit tests parallel with AddressSanitizer option.
test_tsan_parallel: tsan ## Run unit tests parallel with ThreadSanitizer option.
##
## ================ distribution ================
release:                 ## Build vsag with release options.
distribution:            ## Build vsag with distribution options.
libcxx:                  ## Build vsag using libc++.
pyvsag:                  ## Build pyvsag wheel.
clean-release:           ## Clear build-release/ directory.
install:                 ## Build and install the release version of vsag.

@wxyucs wxyucs added the kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) label Dec 27, 2024
@wxyucs wxyucs requested a review from LHT129 December 27, 2024 06:38
@wxyucs wxyucs self-assigned this Dec 27, 2024
@wxyucs wxyucs requested a review from jiaweizone as a code owner December 27, 2024 06:38
@wxyucs wxyucs force-pushed the update-makefile branch 4 times, most recently from d872a81 to 9fc5d71 Compare December 30, 2024 03:23
Makefile Show resolved Hide resolved
@wxyucs wxyucs requested a review from inabao as a code owner December 30, 2024 10:10
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 31, 2024
@wxyucs wxyucs changed the title update makefile to make it clear update makefile and remove outdated benchs directory Dec 31, 2024
@wxyucs wxyucs force-pushed the update-makefile branch 3 times, most recently from f728ab5 to 948fb59 Compare January 2, 2025 08:35
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 7 files with indirect coverage changes

Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.PHONY: debug
debug: ## Build vsag with debug options.
cmake ${VSAG_CMAKE_ARGS} -B${DEBUG_BUILD_DIR} -DCMAKE_BUILD_TYPE=Debug -DENABLE_CCACHE=ON -DENABLE_ASAN=OFF
cmake ${VSAG_CMAKE_ARGS} -B${DEBUG_BUILD_DIR} -DCMAKE_BUILD_TYPE=Debug -DENABLE_ASAN=OFF -DENABLE_CCACHE=ON
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can set ENABLE_EXAMPLES=ON?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the default value of ENABLE_EXAMPLES in another pull request

Copy link
Collaborator

@LHT129 LHT129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wxyucs wxyucs merged commit 929796e into main Jan 3, 2025
10 checks passed
@wxyucs wxyucs deleted the update-makefile branch January 3, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants