Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve coverage rate #330

Merged
merged 1 commit into from
Jan 16, 2025
Merged

improve coverage rate #330

merged 1 commit into from
Jan 16, 2025

Conversation

LHT129
Copy link
Collaborator

@LHT129 LHT129 commented Jan 15, 2025

  • improve coverage on brute force

@LHT129 LHT129 added the kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) label Jan 15, 2025
@LHT129 LHT129 self-assigned this Jan 15, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
+ Coverage   86.29%   86.95%   +0.65%     
==========================================
  Files         114      115       +1     
  Lines        7115     7113       -2     
==========================================
+ Hits         6140     6185      +45     
+ Misses        975      928      -47
Flag Coverage Δ
cpp 86.95% <100.00%> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 90.67% <100.00%> (+0.87%) ⬆️
datacell 90.34% <ø> (+0.06%) ⬆️
index 85.07% <ø> (+0.82%) ⬆️
simd 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfd685a...e5d51d4. Read the comment docs.

@LHT129 LHT129 force-pushed the coverage branch 4 times, most recently from 0828f1a to 004ce33 Compare January 15, 2025 06:30
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 15, 2025
wxyucs
wxyucs approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LHT129 LHT129 force-pushed the coverage branch 2 times, most recently from 91738fe to 7a21333 Compare January 16, 2025 03:21
@LHT129
improve coverage rate
e5d51d4 
- improve coverage on brute force
- remove unused function
- add parameter ToJson test

Signed-off-by: LHT129 <[email protected]>
inabao
inabao approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@inabao inabao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHT129 LHT129 merged commit a84d5c9 into antgroup:main Jan 16, 2025
14 of 16 checks passed
@LHT129 LHT129 deleted the coverage branch January 16, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShawnShawnYou ShawnShawnYou ShawnShawnYou approved these changes

@inabao inabao inabao approved these changes

@wxyucs wxyucs wxyucs approved these changes

@jiaweizone jiaweizone Awaiting requested review from jiaweizone jiaweizone is a code owner

Assignees

@LHT129 LHT129

Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/L version/0.13
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LHT129 @wxyucs @inabao @ShawnShawnYou