Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize the implementation logic of TestSerializeReaderSet #332

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

inabao
Copy link
Collaborator

@inabao inabao commented Jan 15, 2025

No description provided.

@inabao inabao requested a review from LHT129 January 15, 2025 10:05
@inabao inabao self-assigned this Jan 15, 2025
@inabao inabao added kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) version/0.13 and removed size/M labels Jan 15, 2025
Copy link
Collaborator

@LHT129 LHT129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   85.86%   86.22%   +0.36%     
==========================================
  Files         109      114       +5     
  Lines        6798     7101     +303     
==========================================
+ Hits         5837     6123     +286     
- Misses        961      978      +17     
Flag Coverage Δ
cpp 86.22% <ø> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 89.80% <ø> (+0.31%) ⬆️
datacell 90.03% <ø> (+0.95%) ⬆️
index 84.20% <ø> (+0.20%) ⬆️
simd 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b663e67...e9c1581. Read the comment docs.

@inabao inabao merged commit 09fd74e into main Jan 16, 2025
14 of 16 checks passed
@inabao inabao deleted the optimize-test-serialize-reader-set branch January 16, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) version/0.13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants