Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add index persistent example #339

Merged
merged 1 commit into from
Jan 23, 2025
Merged

add index persistent example #339

merged 1 commit into from
Jan 23, 2025

Conversation

wxyucs
Copy link
Collaborator

@wxyucs wxyucs commented Jan 16, 2025

No description provided.

@wxyucs wxyucs added the kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) label Jan 16, 2025
@wxyucs wxyucs self-assigned this Jan 16, 2025
@wxyucs wxyucs requested a review from jiaweizone as a code owner January 16, 2025 13:36
@wxyucs wxyucs force-pushed the add-persistent-example branch from b05f3ef to 1691366 Compare January 16, 2025 13:40
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   87.70%   90.84%   +3.13%     
==========================================
  Files         131      133       +2     
  Lines        8540     8429     -111     
==========================================
+ Hits         7490     7657     +167     
+ Misses       1050      772     -278     
Flag Coverage Δ
cpp 90.84% <ø> (+3.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 94.84% <ø> (+6.16%) ⬆️
datacell 91.77% <ø> (+1.59%) ⬆️
index 91.11% <ø> (-0.02%) ⬇️
simd 81.63% <ø> (+12.34%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 206fa94...e5a87eb. Read the comment docs.

@wxyucs wxyucs force-pushed the add-persistent-example branch from 1691366 to a8bf288 Compare January 21, 2025 03:12
@LHT129 LHT129 self-requested a review January 22, 2025 07:18
Signed-off-by: Xiangyu Wang <[email protected]>
@wxyucs wxyucs force-pushed the add-persistent-example branch from 5f5bfef to e5a87eb Compare January 22, 2025 07:48
Copy link
Collaborator

@LHT129 LHT129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@inabao inabao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wxyucs wxyucs merged commit f1c0cfc into main Jan 23, 2025
15 of 16 checks passed
@wxyucs wxyucs deleted the add-persistent-example branch January 23, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/L version/0.13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants