support allocator in conjugate graph #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShawnShawnYou
added
kind/improvement
ShawnShawnYou
force-pushed
the
support-allocator-in-conjugate-graph
branch
2 times, most recently
from
ab168d3 to
bb8ac72
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #344 +/- ##
==========================================
- Coverage 90.26% 87.73% -2.53%
==========================================
Files 118 134 +16
Lines 7372 8613 +1241
==========================================
+ Hits 6654 7557 +903
- Misses 718 1056 +338
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
jiaweizone
reviewed
Jan 20, 2025
src/impl/conjugate_graph.cpp
Outdated
| conjugate_graph_.emplace(from_tag_id, std::make_shared<UnorderedSet<int64_t>>(allocator_)); | ||
| } | ||
|
|
||
| auto neighbor_set = conjugate_graph_[from_tag_id]; |
There was a problem hiding this comment.
here can reduce search cost
| @@ -169,7 +179,8 @@ ConjugateGraph::Deserialize(const Binary& binary) { | |||
|
|
|||
| int64_t cursor = 0; | |||
| ReadFuncStreamReader reader(func, cursor); | |||
| return this->Deserialize(reader); | |||
| BufferStreamReader buffer_reader(&reader, binary.size, allocator_); | |||
| return this->Deserialize(buffer_reader); | |||
There was a problem hiding this comment.
add buffer read optimize ?
ShawnShawnYou
force-pushed
the
support-allocator-in-conjugate-graph
branch
2 times, most recently
from
27484c2 to
1cc0b11
Compare
LHT129
reviewed
Jan 21, 2025
src/impl/conjugate_graph_test.cpp
Outdated
| @@ -44,8 +46,9 @@ TEST_CASE("build, add and memory usage", "[ut][conjugate_graph]") { | |||
| } | |||
|
|
|||
| TEST_CASE("serialize and deserialize with binary", "[ut][conjugate_graph]") { | |||
| vsag::DefaultAllocator allocator; | |||
There was a problem hiding this comment.
use safe allocator's method
Signed-off-by: zhongxiaoyao.zxy <[email protected]>
ShawnShawnYou
force-pushed
the
support-allocator-in-conjugate-graph
branch
from
1cc0b11 to
6f49bac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support allocator in conjugate graph