Support SYSTEM_ALERT_WINDOW through Settings.canDrawOverlays() #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 24, 2016 23:38
This prepares the method to call Settings.canDrawOverlay().
checkSelfPermission() always returns PERMISSION_DENIED for SYSTEM_ALERT_WINDOW as it is supposedly a dangerous 'special' permission which needs to be granted through an Intent.
|
Hmm, maybe this isn't the correct way to handle this! I guess it would be better if Then we should add a note to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getPermissionsListToRequest() uses ActivityCompat.checkSelfPermission() to check if the permission is granted.
SYSTEM_ALERT_WINDOW is a 'special' dangerous permission, requiring the grant process through a special Settings.ACTION_MANAGE_OVERLAY_PERMISSION intent. Apparently, even if granting the access through the new Activity, ActivityCompat.checkSelfPermission() will return PERMISSION_DENIED.
I propose this tiny fix with uses Settings.canDrawOverlays() for SYSTEM_ALERT_WINDOW instead. Before requestAllManifestPermissionsIfNecessary() always called onDenied() if you worked with the special permission despite granting all other permissions access!