Add ConfigureAwait(false) to await calls #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks like a good idea - I'll pull this in. |
|
That's awesome. Thanks! |
|
Hey sorry to bug you again. Any chance this can be merged soon? Thanks! |
sorry for the delay, got pulled away on another project, but I'll get this out in the next few weeks |
|
Please, complete PR |
|
I'll have the beta nuget package published tomorrow |
|
published in 5.0.0-Beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows this library to be used in places where async await is not supported. Adding ConfigureAwait(false) prevents synchronization context from hanging when using Wait or Result