Add option to reuse pre-rendered markup & to reuse DOM nodes #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
June 1, 2016 17:13
…n to do checksum comparison) This reverts commit b631711. Add tests & doc for string-eq-based self-healing (i.e. autoFix) Add string-eq-based self-healing fix basic example to adapt new createApp behavoir add test for pre-render HTML event handling Modify setAttribute to accept an option parameter Reconstruct createElement so the side effects are now accessible Implement event handler registration for pre rendered HTML Rebase fix
Add failing rerender test Add path-based virtualdom restoration on client-side libs cleanup
get rid of uids on server Remove generator to avoid regenerator runtime
|
Thanks for the PR @heilage-nsk! I'm going to have a read through this soon and give you some feedback. |
|
+1 |
|
Looks good to me! The pooling seems like it could exist in an another module rather than living inside Deku, but we can move this out at a later stage. Nice work! For the thunk, having nested thunks with the same path could break anything using the path to store state, so we might need to fix that before we can merge it in. |
|
@anthonyshort |
|
+1 |
|
+1? @anthonyshort maybe merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've taken 0a's changes from #395 and #396, slightly refactored them to comply with current codebase and added some more things, such as possibility to reuse already created nodes to minimize memory usage.
Also relates to #190
I still have a TODO to resolve (see question in test/app/thunk.js), any advice is appreciated. Also I'm not sure if all of these changes should be in the mainline or it's better to make them as a plugin.
Bench for uibench ( https://localvoid.github.io/uibench/ ) may be run with this custom link: https://heilage-nsk.github.io/uibench-deku/
Headless tests are passing, but for some reason Electron fails to start on my system, so I cannot check it :( I'd be glad if someone would try to run tests on Electron and share the results.