Implement new Square checkout flow #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required updating all of the Python dependencies. Reportlab and Pillow have been unpinned.
Entvanen
reviewed
Oct 16, 2023
| @admin.display(description='Artist') | ||
| def clickable_artist(self, obj): | ||
| return format_html('<a href="{}">{}</a>', | ||
| reverse('admin:artshow_artist_change', |
There was a problem hiding this comment.
Reverse takes a reference to a route and generates a (relative) URL which will resolve to the route. In this example it will generate a URL which links to the admin page for editing the given artist. In this case I think Django now supports this particular case as a built-in feature: https://docs.djangoproject.com/en/4.2/ref/contrib/admin/#django.contrib.admin.ModelAdmin.list_display_links
There was a problem hiding this comment.
Never mind, that's not what list_display_links does.
Entvanen
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the inline credit card form with a system for creating real Square payment links, similar to the Paypal integration. The ability to specify an arbitrary payment amount has been removed. Payment completion is signaled via a webhook. For auditing purposes all valid webhook calls are logged.