Added fake.emailAddress #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcodejongh
force-pushed
the
Added_emailaddress
branch
from
a7d1047
to
3d3c6c6
Compare
| @@ -138,6 +138,9 @@ var randomElement = function(array) { | |||
| return array[Math.floor(Math.random() * array.length)]; | |||
| }; | |||
|
|
|||
| var generateEmailAddress = function (username, domain) { | |||
| return (name + '@' + domain).toLowerCase(); | |||
There was a problem hiding this comment.
Didn't you intend for the parameter name to match the usage?
var generateEmailAddress = function (name, domain) {There was a problem hiding this comment.
Yes I did, noticed the mistake myself and amended my commit. But for some reason the push timed out. Check again.
marcodejongh
force-pushed
the
Added_emailaddress
branch
from
3d3c6c6
to
d526586
Compare
|
@marcodejongh A useful thing! Thank you for this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed generation of fake email address.
So you don't need to generate a whole user just for the email address.