Skip to content

Commit

Permalink
add official support of drupal 10.3
Browse files Browse the repository at this point in the history
  • Loading branch information
WengerK committed Aug 19, 2024
1 parent d37fab3 commit 20afa25
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

strategy:
matrix:
drupal_version: ['9.5', '10.0', '10.1', '10.2']
drupal_version: ['9.5', '10.0', '10.1', '10.2', '10.3']
module: ['factory_lollipop']
experimental: [false]

Expand All @@ -39,7 +39,7 @@ jobs:

strategy:
matrix:
drupal_version: ['9.5', '10.0', '10.1', '10.2']
drupal_version: ['9.5', '10.0', '10.1', '10.2', '10.3']
module: ['factory_lollipop']
experimental: [ false ]

Expand Down
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ variables:
SKIP_ESLINT: '1'
# Opt in to testing current minor against max supported PHP version.
OPT_IN_TEST_MAX_PHP: '1'
# Opt in to testing previous & next minor (Drupal 10.0.x and 10.2.x).
# Opt in to testing previous & next minor (Drupal 10.1.x and 10.3.x).
OPT_IN_TEST_PREVIOUS_MINOR: '1'
OPT_IN_TEST_NEXT_MINOR: '1'
# Opt in to testing $CORE_PREVIOUS_MAJOR (currently Drupal 9.5).
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- fix obsolete docker-compose command in CIs

### Added
- add official support of drupal 10.3

### Removed
- remove legacy version annotation on docker-compose.yml

Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ on your environment:

Once run, you will be able to access to your fresh installed Drupal on `localhost::8888`.

docker-compose build --pull --build-arg BASE_IMAGE_TAG=10.1 drupal
docker-compose build --pull --build-arg BASE_IMAGE_TAG=10.2 drupal
# (get a coffee, this will take some time...)
docker compose up -d drupal
docker compose exec -u www-data drupal drush site-install standard --db-url="mysql://drupal:drupal@db/drupal" -y
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG BASE_IMAGE_TAG=10.1
ARG BASE_IMAGE_TAG=10.2
FROM wengerk/drupal-for-contrib:${BASE_IMAGE_TAG}

ARG BASE_IMAGE_TAG
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ public function testDefine(): void {
self::assertSame('parent', $link->label());
self::assertSame('parent', $link->getTitle());
self::assertInstanceOf(Url::class, $link->toUrl());
self::assertSame('route:entity.menu_link_content.canonical;menu_link_content=1', $link->toUrl()->toUriString());
self::assertSame('/admin/structure/menu/item/1/edit', $link->toUrl()->toString());
self::assertSame('menu_test', $link->getMenuName());
self::assertStringStartsWith('menu_link_content:', $link->getPluginId());
Expand Down
1 change: 0 additions & 1 deletion tests/src/Kernel/FactoryType/MenuLinkFactoryTypeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ public function testCreate(): void {
self::assertSame('Menu link test', $link->label());
self::assertSame('Menu link test', $link->getTitle());
self::assertInstanceOf(Url::class, $link->toUrl());
self::assertSame('route:entity.menu_link_content.canonical;menu_link_content=1', $link->toUrl()->toUriString());
self::assertSame('/admin/structure/menu/item/1/edit', $link->toUrl()->toString());
self::assertSame('menu_test', $link->getMenuName());
self::assertStringStartsWith('menu_link_content:', $link->getPluginId());
Expand Down

0 comments on commit 20afa25

Please sign in to comment.