-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Fix for 3847 -- fix build. The following targets fail the build: * asm/ptx/ptx-isa-1.0 with Cpp: NAN is a symbol conflict for Cpp--apparently now for MacOS. ./icon ./lark .sieve ./smtlibv2 ./wavefront with Go target--symbol conflict apparently now with "start" as a parser rule. * ./scala with Go target--timeout. This grammar is super slow. Go target should be removed from desc.xml to indicate it doesn't work. * elixir with PHP target--stack overflow. The PHP has logical errors in the code. I tried to address some of the problems, but it was too much, and needed to work on other things. Fix for #12 -- Allowed memory size of 134217728 bytes exhausted. antlr-php-runtime#34 * Fix problem with "options=" parse errors in tool Workaround the issue in tool antlr/antlr4#4474 by renaming the rule element label.
- Loading branch information
Showing
11 changed files
with
12 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -298,7 +298,7 @@ cmp_op | |
| GTU | ||
| GEU | ||
| NUM | ||
| NAN | ||
| NAN_ | ||
; | ||
|
||
bool_op | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
<?xml version="1.0" encoding="UTF-8" ?> | ||
<desc xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../_scripts/desc.xsd"> | ||
<!-- Although they work, the Go and Python targets are excluded since they are very slow --> | ||
<targets>CSharp;Dart;Java;JavaScript;PHP;TypeScript</targets> | ||
<!-- Although they work, the Go, PHP, and Python targets are excluded since they are very slow --> | ||
<targets>CSharp;Dart;Java;JavaScript;TypeScript</targets> | ||
</desc> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
<?xml version="1.0" encoding="UTF-8" ?> | ||
<desc xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../_scripts/desc.xsd"> | ||
<targets>CSharp;Cpp;Dart;Go;Java;JavaScript;TypeScript;Python3</targets> | ||
<targets>CSharp;Cpp;Dart;Java;JavaScript;TypeScript;Python3</targets> | ||
<entry-point>compilationUnit</entry-point> | ||
</desc> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -485,7 +485,7 @@ UndefinedSymbol: | |
|
||
// Starting rule(s) | ||
|
||
start | ||
start_ | ||
: logic EOF | ||
| theory_decl EOF | ||
| script EOF | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ grammar WavefrontOBJ; | |
|
||
// PARSER RULES | ||
|
||
start | ||
start_ | ||
: NL* (statement (NL+ | EOF))+ | ||
; | ||
|
||
|
e453816
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaby76 Why did you commit this patch? We discussed it in my patch that I cherry picked it to avoid merge conflicts. Now exactly that happens and I have to rebase and start the entire build process again. That was not wise...
e453816
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left the PR as "ready" when I should have been marked "draft". Then, after you merged the changes, I would "cancel" my PR. It did cross my mind that there might be a screw up, and that's what happened. @teverett merged it into "master". I don't think you have to deal with the conflict. @teverett should just select everything in your PR over my PR when using the "merge PR" for the repo in the Github UI. If it can't be done in the website UI, just merge and resolve conflicts using Github Desktop. I don't think you need to rebase; your code is fine.
e453816
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake :)
e453816
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a big problem. I just wouldn't do any merges until this huge PR is merged first.
e453816
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, no worries. Let's see if that works now...