Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Chisel 6.x #22

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Port to Chisel 6.x #22

wants to merge 5 commits into from

Conversation

kammoh
Copy link

@kammoh kammoh commented Jan 30, 2024

This PR contains 2 separate changes:

  • Upgrade to Chisel 6.0.0
  • Port build system from sbt to mill

I have only done very limited simulation test on the changes. I don't think the changes (including port to chisel 6) are likely to break the functionality but nevertheless more extensive testing is recommended.

I understand that the changes should preferably be split into two PRs and that the change of the build system might not be desirable by the maintainers. Unfortunately at this time I won't be able to split the PR. Please feel free to cherry pick, split, or make any changes to this PR!

@kammoh kammoh changed the title Upgrade to Chisel 6.x Port to Chisel 6.x Jan 30, 2024
@kgugala
Copy link
Member

kgugala commented Jan 31, 2024

hi @kammoh thanks for the contribution. The changes look good, but it seems that the CI was not triggered in the PR - this is due to misconfiguration in the CI yaml file. This has been fixed on main. Can you rebase your PR on top of that, so that the CI is triggered here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants