Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(primitives): Remove Block Mod #524

Closed
wants to merge 2 commits into from
Closed

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Sep 12, 2024

Description

Removes the block mod from kona-primitives.

Will make future prs easier to use op-alloy block types.

Updated two issues to track removing these two block types:

Copy link
Collaborator Author

refcell commented Sep 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 77.0%. Comparing base (24e8e41) to head (f629738).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
crates/primitives/src/payload.rs 0.0% 10 Missing ⚠️
crates/derive/src/online/alloy_providers.rs 0.0% 3 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell changed the title chore: remove block mod in kona-primitives chore(primitives): Remove Block Mod Sep 12, 2024
@refcell refcell requested a review from clabby September 12, 2024 16:32
@refcell refcell added A-primitives K-chore Kind: chore labels Sep 12, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review September 12, 2024 16:32
@refcell refcell self-assigned this Sep 12, 2024
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in case you wanna get this in; We can also wait until the types are actually in alloy if you prefer, though. Feel free to merge if this makes that migration easier eventually.

@refcell refcell added the M-do-not-merge Meta: Do not merge label Sep 13, 2024
@refcell
Copy link
Collaborator Author

refcell commented Sep 23, 2024

Closed by #542

@refcell refcell closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
K-chore Kind: chore M-do-not-merge Meta: Do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants