Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(driver): Refactor Driver out of Client #794

Merged
merged 2 commits into from
Nov 8, 2024
Merged

feat(driver): Refactor Driver out of Client #794

merged 2 commits into from
Nov 8, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Nov 7, 2024

Description

Refactors the driver out of kona-client and into a new crate with trait abstractions.

Metadata

Fixes #765

@refcell refcell requested a review from clabby as a code owner November 7, 2024 22:30
@refcell refcell added A-client Area: client binary K-feature Kind: feature labels Nov 7, 2024
@refcell
Copy link
Collaborator Author

refcell commented Nov 7, 2024

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@refcell refcell self-assigned this Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 106 lines in your changes missing coverage. Please review.

Project coverage is 92.5%. Comparing base (d50844c) to head (8ab1742).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/driver/src/core.rs 0.0% 81 Missing ⚠️
crates/driver/src/cursor.rs 0.0% 16 Missing ⚠️
crates/driver/src/errors.rs 0.0% 9 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby added this pull request to the merge queue Nov 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 8, 2024
@refcell refcell added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit b79054a Nov 8, 2024
14 of 16 checks passed
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-client Area: client binary K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(client,driver): Refactor and Introduce kona-driver
2 participants