Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

fix: addresses review comments #155

Merged
merged 6 commits into from
Nov 3, 2023
Merged

fix: addresses review comments #155

merged 6 commits into from
Nov 3, 2023

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Nov 2, 2023 •
edited
Loading

@refcell refcell self-assigned this Nov 2, 2023
@refcell refcell mentioned this pull request Nov 2, 2023
Merged
@refcell refcell changed the title fix(rpc): OptimismTxMeta fix: addresses review comments Nov 3, 2023
clabby
clabby approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Looks like you're having the same fmt problem I am w/ trailing_semicolon fmt rule not being respected in latest nightly. Matt's been nitting that, should prob remove the trailing semicolons manually.

@refcell refcell merged commit 45017e6 into clabby/op-reth Nov 3, 2023
9 of 16 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clabby clabby clabby approved these changes

@merklefruit merklefruit Awaiting requested review from merklefruit

Assignees

@refcell refcell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @clabby