feat(ava): add polar animate, and encode date column #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
commit message scope 规范 需要加上修改的模块 |
chenluli
reviewed
Nov 10, 2023
| const dp = dataProps.find((dataProp) => dataProp.name === field); | ||
|
|
||
| if (dp?.recommendation === 'date') { | ||
| return (d) => new Date(d[field]); |
There was a problem hiding this comment.
要不判断下是否能转成 date 吧，如果是 invalid date，还是输出原 field
There was a problem hiding this comment.
那会不会有些转了，有些没转？
嗯 如果部分转了，部分没转确实也会有问题 但不判断的话，可能会导致值都被转成 invalid date 了，严谨点的话需要判断所有的都能转，才做这个转换？
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes