Skip to content

Commit

Permalink
fix: 回滚手势全局触发,会带来严重的性能问题 (#1490)
Browse files Browse the repository at this point in the history
  • Loading branch information
zengyue authored Aug 16, 2023
1 parent 992e9d5 commit 5807129
Showing 1 changed file with 2 additions and 25 deletions.
27 changes: 2 additions & 25 deletions packages/g-gesture/src/gesture.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import type {
FederatedPointerEvent,
PointLike as Point,
} from '@antv/g-lite';
import { ElementEvent } from '@antv/g-lite';
import EventEmitter from 'eventemitter3';

const clock =
Expand Down Expand Up @@ -85,32 +84,10 @@ class Gesture extends EventEmitter {

private _initEvent() {
const { el } = this;
if (el.isConnected) {
// @ts-ignore
el.ownerDocument?.defaultView.addEventListener('pointermove', this._move);
} else {
el.isMutationObserved = true;
el.on(ElementEvent.MOUNTED, (e) => {
el.ownerDocument?.defaultView.addEventListener(
'pointermove',
// @ts-ignore
this._move,
);
});
}

el.addEventListener('pointerdown', this._start);

if (el.isConnected) {
// @ts-ignore
el.ownerDocument?.defaultView.addEventListener('pointerup', this._end);
} else {
el.on(ElementEvent.MOUNTED, (e) => {
// @ts-ignore
el.ownerDocument?.defaultView.addEventListener('pointerup', this._end);
});
}

el.addEventListener('pointermove', this._move);
el.addEventListener('pointerup', this._end);
el.addEventListener('pointercancel', this._cancel);
el.addEventListener('pointerupoutside', this._end);
}
Expand Down

0 comments on commit 5807129

Please sign in to comment.